TroubleShooting_Too long to get main page

Posted Jul 17, 2024

By So Hee Park 1 min read

✅ Takes too long to get main page

In developer tools takes 3.83 seconds
In HTTPS postman 4s 25ms
In Localhost postman takes more than 9 minutes!!!

🔵 Tryout 1. Move update code to each service.

First, the update code was inside the for loop.
Thus, making the update for each product each time calling a product.
This was considered to be so inefficient.
Moved the update code outside the for loop.

👎🏻 Before

  
  public List<productListQueryDto> getProductListQueryDto(List<Product> productList) {
        List<productListQueryDto> plqdList = new ArrayList<>();

        for (Product product : productList) {

            productRepository.updateProductSales(); //🔴
            productRepository.updateReviewAvg(); //🔴
            int productLike=productRepository.countLikesByProductId(product.getProductId());
            productListQueryDto plqd = productListQueryDto.builder()
                    .product_id(product.getProductId())
        }

👍🏻 After

  
 public List<productListQueryDto> getProductListQueryDto(List<Product> productList) {
        List<productListQueryDto> plqdList = new ArrayList<>();
        productRepository.updateProductSales(); //🔵outside for loop
        productRepository.updateReviewAvg();

        for (Product product : productList) {
            int productLike=productRepository.countLikesByProductId(product.getProductId());
            productListQueryDto plqd = productListQueryDto.builder()
                    .product_id(product.getProductId())

        }
      }